Merge pull request #165 from lishaduck/partial-sheriff

Enable zero-config Sheriff
AndreaPontrandolfo · Jul 14, 2024 · d1971c3 · d1971c3
2 parents 25a4855 + 0fd4217
commit d1971c3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/.changeset/seven-rules-invite.md b/.changeset/seven-rules-invite.md
@@ -0,0 +1,5 @@
+---
+'eslint-config-sheriff': minor
+---
+
+feat: allow zero-config sheriff
diff --git a/packages/eslint-config-sheriff/src/getExportableConfig.ts b/packages/eslint-config-sheriff/src/getExportableConfig.ts
@@ -3,7 +3,7 @@ import getGitignorePatterns from 'eslint-config-flat-gitignore';
 import lodash from 'lodash';
 import type { FlatESLintConfig } from 'eslint-define-config';
 import { SheriffSettings } from '@sherifforg/types';
-import { ignores } from '@sherifforg/constants';
+import { ignores, sheriffStartingOptions } from '@sherifforg/constants';
 import { getReactConfig } from './getReactConfig';
 import { getBaseConfig } from './getBaseConfig';
 import { nextjsConfig } from './nextjsConfig';
@@ -15,23 +15,18 @@ import { prettierOverrides } from './prettierOverrides';
 import { type TSESLint } from '@typescript-eslint/utils';
 
 export const getExportableConfig = (
-  userConfigChoices: SheriffSettings,
+  userConfigChoices: SheriffSettings = sheriffStartingOptions,
   areAllRulesForced?: boolean,
 ): FlatESLintConfig[] => {
-  if (!userConfigChoices) {
-    throw new Error('No settings provided.');
-  }
-
   let exportableConfig: TSESLint.FlatConfig.ConfigArray = [
     ...getBaseConfig(userConfigChoices),
   ];
 
   if (userConfigChoices.react || userConfigChoices.next) {
     // we insert reactConfig this way because it's an array. It's an array because it contains multiple configs, currently: react, react-hooks, react-a11y and react-refresh.
-    exportableConfig = [
-      ...exportableConfig,
+    exportableConfig.push(
       ...getReactConfig(userConfigChoices.pathsOverrides?.tsconfigLocation),
-    ];
+    );
   }
 
   if (