Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rules #169

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

lishaduck
Copy link
Contributor

@lishaduck lishaduck commented Jul 16, 2024

Some opinionated changes I made. Feel free to close this if you disagree.

  • Label configs for debugging in the ESLint Config Inspector.
  • Switch off deprecated rules.
  • Enable most of the recommended Unicorn rules. (Most controversial commit)

Copy link

changeset-bot bot commented Jul 16, 2024

⚠️ No Changeset found

Latest commit: 6ca90af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sheriff ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 2:06am

@lishaduck lishaduck changed the title Rules update Update Rules Jul 16, 2024
@lishaduck
Copy link
Contributor Author

Docusaurus's ESM support is a sham!1 They're just using Jiti, so this PR requires... the dreaded eslint-disable comment: unjs/jiti#101

Footnotes

  1. Very much an exaggeration, full of hyperbole: Jiti is certainly ESM, they're just not ESM, we have to be... patient! 😜

This was probably an intentional omission, but I think it's better to manually disable these rules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant