Fix for issue 52 #60
Open
Fix for issue 52 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ivity Fixes AndreiLux#52 Logcat showed that error happened while invoking onConfigurationChanged method in mDrawerToggle, but didn't provide crash info. Forcing portrait layout until all fragments have been loaded fixes rotation bug on loading app. setRequestedOrientation will block invoking onConfigurationChanged for orientation events, but screenSize changes when orientation is changed will invoke it, thus avoiding this bug and properly notifying mDrawerToggle.
Commit: 464d92f fixed issue AndreiLux#52 That commit also made new bug (or rather exposed what was happening in AndreiLux#52). On each rotation, Settings was unable to instantiate MyPreferenceFragment. Each time rotation changed while user was in settings menu, Synapse would crash due to InstantiationException Fix this by moving MyPreferenceFragment out of Settings and making it outer standalone class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52
Logcat showed that error happened while invoking onConfigurationChanged method in mDrawerToggle, but didn't provide crash info.
Forcing portrait layout until all fragments have been loaded fixes rotation bug on loading app.
setRequestedOrientation will block invoking onConfigurationChanged for orientation events, but screenSize changes when orientation is changed will invoke it, thus avoiding this bug and properly notifying mDrawerToggle.
Forcing orientation made (or rather exposed what was happening in #52 ) new bug. Each time user rotated screen while in settings menu, Synapse would crash with InstantiationException for MyPreferenceFragment.
I fixed this by moving MyPreferenceFragment class to separate file and passing settings activity context via variable Utils.settingsActivity.
This effectively fixed all bugs I have noticed related to #52