Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development towards 0.5.0 #20

Merged
merged 15 commits into from
May 9, 2024
Merged

Development towards 0.5.0 #20

merged 15 commits into from
May 9, 2024

Conversation

AndrejOrsula
Copy link
Owner

@AndrejOrsula AndrejOrsula commented Apr 21, 2024

Other significant API changes for the generated bindings

  1. Calling methods of class MyClass(pyo3::PyAny) encapsulated as pyo3::Bound<'_, MyClass> is now a bit more cumbersome. It requires that use MyClassMethods; is included in the scope when such methods are used. This follows the API design of PyO3, where all methods are implemented under a trait (e.g. pyo3::types::PyAnyMethods) due to arbitrary_self_types being unstable.
  2. Passing of ::pyo3::marker::Python<'py> is no longer necessary for methods. It is extracted from self directly.

Signed-off-by: Andrej Orsula <[email protected]>
Signed-off-by: Andrej Orsula <[email protected]>
- Fix only breaking changes for now

Signed-off-by: Andrej Orsula <[email protected]>
Signed-off-by: Andrej Orsula <[email protected]>
Signed-off-by: Andrej Orsula <[email protected]>
Signed-off-by: Andrej Orsula <[email protected]>
Signed-off-by: Andrej Orsula <[email protected]>
Signed-off-by: Andrej Orsula <[email protected]>
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 68.30835% with 148 lines in your changes are missing coverage. Please review.

Project coverage is 66.77%. Comparing base (6466a7f) to head (2494035).
Report is 1 commits behind head on main.

Files Patch % Lines
pyo3_bindgen_engine/src/typing/into_rs.rs 33.87% 82 Missing ⚠️
pyo3_bindgen_engine/src/syntax/module.rs 69.13% 25 Missing ⚠️
...en_engine/src/syntax/common/function_definition.rs 0.00% 12 Missing ⚠️
pyo3_bindgen_engine/src/codegen.rs 70.83% 7 Missing ⚠️
pyo3_bindgen_engine/src/syntax/function.rs 86.53% 7 Missing ⚠️
pyo3_bindgen_engine/src/syntax/property.rs 90.78% 7 Missing ⚠️
pyo3_bindgen_engine/src/typing/from_py.rs 73.33% 4 Missing ⚠️
pyo3_bindgen_engine/src/syntax/class.rs 95.23% 3 Missing ⚠️
pyo3_bindgen_macros/src/utils.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   67.45%   66.77%   -0.69%     
==========================================
  Files          21       22       +1     
  Lines        3008     3211     +203     
==========================================
+ Hits         2029     2144     +115     
- Misses        979     1067      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndrejOrsula AndrejOrsula changed the title Development Development towards 0.5.0 May 9, 2024
@AndrejOrsula AndrejOrsula marked this pull request as ready for review May 9, 2024 18:44
@AndrejOrsula AndrejOrsula merged commit 64c64a5 into main May 9, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant