Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy fix #29

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Clippy fix #29

merged 2 commits into from
Sep 17, 2024

Conversation

NiklasVousten
Copy link
Contributor

Solves issue with missing cfg(PyPy), and so on

Updating the pyo3-build-config crate was enough.
Additionally cargo update was run

Added #[cfg(unix)] to pyo3_bindgen_macros utils.rs to fix unused import error

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.55%. Comparing base (64c64a5) to head (1425361).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   66.77%   66.55%   -0.22%     
==========================================
  Files          22       22              
  Lines        3211     3199      -12     
==========================================
- Hits         2144     2129      -15     
- Misses       1067     1070       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@AndrejOrsula AndrejOrsula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks a lot, @NiklasVousten, for your contributions!

@AndrejOrsula AndrejOrsula merged commit cd5f278 into AndrejOrsula:main Sep 17, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants