added type support for passing date as a number #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the ? condition seems redundant, but needed for typescript type guard to work. otherwise (at least in TS 2.7.2) it doesn't know to pick the right Date constructor based on the type of value
This fix is needed for IDEs to not complain about type mismatch, e.g. in cases such as
`{{ item.modifiedDate | timeAgo }}`
in case modified date is a number.
It works in practice because Date has a constructor that accepts number (milliseconds time stamp), but some IDEAs will complain about the pipe accepting only strings where the attribute is a number.
eranation
commented
Apr 3, 2019
| this.removeTimer(); | ||
| let d = new Date(value); | ||
| let d = typeof value === 'string' ? new Date(value) : new Date(value); |
There was a problem hiding this comment.
The condition here is required unfortunately (at least in TypeScript 2.7.2) - this ensures the type guards treat the first Date(value) as string and the second as number. Without it, TypeScript compiler complains (it won't auto select the matching constructor unfortunately)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is needed for IDEs to not complain about type mismatch, e.g. in cases such as
{{ item.modifiedDate | timeAgo }}in case modified date is a number.
It works in practice because Date has a constructor that accepts number (milliseconds time stamp), but some IDEAs will complain about the pipe accepting only strings where the attribute is a number.
note: the ? condition seems redundant, but needed for typescript type guard to work. otherwise (at least in TS 2.7.2) it doesn't know to pick the right Date constructor based on the type of value