Feat/tests unit and fuzz #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -486,8 +492,6 @@ abstract contract BaseStrategy is ERC4626, AccessControl { | |||
| * @custom:requires INTEGRATOR_ROLE | |||
| */ | |||
| function setVestingPeriod(uint64 newVestingPeriod) external onlyRole(INTEGRATOR_ROLE) { | |||
There was a problem hiding this comment.
I thought it wasn't in our best interest to set boundaries for a vesting period
| abi.encode(50e18) | ||
| ); | ||
| uint256 maxRedeem = strategy.maxRedeem(alice); | ||
| assertEq(maxRedeem, strategy.convertToShares(50e18)); |
There was a problem hiding this comment.
Instead of doing strategy.convertToShares(50e18) can we compute the actual number, just to have at least one place where we do the actual computation
| abi.encode(50e18) | ||
| ); | ||
| uint256 maxWithdraw = strategy.maxWithdraw(alice); | ||
| assertEq(maxWithdraw, 50e18); |
There was a problem hiding this comment.
It would be great also to have a test on the minimum of a user balance
| ); | ||
| assertEq( | ||
| strategy.maxMint(alice), | ||
| 115625846136565629368682392502753472473372881815114206356643976577531593328100 |
GuillaumeNervoXS
approved these changes
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.