fix: playlist relation might be null in track when cascade (#743)

AnimeThemes · Sep 11, 2024 · 3acac99 · 3acac99
1 parent eeff29b
commit 3acac99
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/app/Events/List/ExternalProfile/ExternalEntry/ExternalEntryDeleted.php b/app/Events/List/ExternalProfile/ExternalEntry/ExternalEntryDeleted.php
@@ -7,6 +7,7 @@
 use App\Events\Base\List\ListDeletedEvent;
 use App\Models\List\ExternalProfile;
 use App\Models\List\External\ExternalEntry;
+use Illuminate\Support\Str;
 
 /**
  * Class ExternalEntryDeleted.
@@ -18,9 +19,9 @@ class ExternalEntryDeleted extends ListDeletedEvent
     /**
      * The profile the entry belongs to.
      *
-     * @var ExternalProfile
+     * @var ExternalProfile|null
      */
-    protected ExternalProfile $profile;
+    protected ?ExternalProfile $profile;
 
     /**
      * Create a new event instance.
@@ -62,6 +63,8 @@ public function getModel(): ExternalEntry
      */
     protected function getDiscordMessageDescription(): string
     {
-        return "Entry '**{$this->getModel()->getName()}**' has been deleted for External Profile '**{$this->profile->getName()}**'.";
+        return Str::of("Entry '**{$this->getModel()->getName()}**' has been deleted")
+            ->append($this->profile ? " for External Profile '**{$this->profile->getName()}**'." : '.')
+            ->__toString();
     }
 }
diff --git a/app/Events/List/Playlist/Track/TrackDeleted.php b/app/Events/List/Playlist/Track/TrackDeleted.php
@@ -7,6 +7,7 @@
 use App\Events\Base\List\ListDeletedEvent;
 use App\Models\List\Playlist;
 use App\Models\List\Playlist\PlaylistTrack;
+use Illuminate\Support\Str;
 
 /**
  * Class TrackDeleted.
@@ -18,9 +19,9 @@ class TrackDeleted extends ListDeletedEvent
     /**
      * The playlist the track belongs to.
      *
-     * @var Playlist
+     * @var Playlist|null
      */
-    protected Playlist $playlist;
+    protected ?Playlist $playlist;
 
     /**
      * Create a new event instance.
@@ -62,6 +63,8 @@ public function getModel(): PlaylistTrack
      */
     protected function getDiscordMessageDescription(): string
     {
-        return "Track '**{$this->getModel()->getName()}**' has been deleted for Playlist '**{$this->playlist->getName()}**'.";
+        return Str::of("Track '**{$this->getModel()->getName()}**' has been deleted")
+            ->append($this->playlist ? " for Playlist '**{$this->playlist->getName()}**'." : '.')
+            ->__toString();
     }
 }