tests: fixed submission rule (#718)

AnimeThemes · Jul 29, 2024 · 89fe315 · 89fe315
1 parent c02840a
commit 89fe315
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 22 deletions.
diff --git a/app/Enums/Models/Wiki/ResourceSite.php b/app/Enums/Models/Wiki/ResourceSite.php
@@ -121,7 +121,7 @@ public static function parseIdFromLink(string $link): ?string
             ResourceSite::NETFLIX,
             ResourceSite::LIVECHART,
             ResourceSite::APPLE_MUSIC => Str::match('/\d+/', $link),
-        //    ResourceSite::ANIME_PLANET => ResourceSite::parseAnimePlanetIdFromLink($link),
+            ResourceSite::ANIME_PLANET => ResourceSite::parseAnimePlanetIdFromLink($link),
             ResourceSite::KITSU => ResourceSite::parseKitsuIdFromLink($link),
             default => null,
         };

diff --git a/app/Policies/Admin/FeaturePolicy.php b/app/Policies/Admin/FeaturePolicy.php
@@ -45,7 +45,7 @@ public function view(?User $user, Feature $feature): bool
             return $user !== null && $user->can(CrudPermission::VIEW->format(Feature::class));
         }
 
-        return true;
+        return $feature->isNullScope();
     }
 
     /**

diff --git a/app/Policies/Admin/FeaturedThemePolicy.php b/app/Policies/Admin/FeaturedThemePolicy.php
@@ -47,7 +47,7 @@ public function view(?User $user, FeaturedTheme $featuredtheme): bool
             return $user !== null && $user->can(CrudPermission::VIEW->format(FeaturedTheme::class));
         }
 
-        return true;
+        return $featuredtheme->start_at->isBefore(Date::now());
     }
 
     /**

diff --git a/app/Rules/Wiki/Submission/SubmissionRule.php b/app/Rules/Wiki/Submission/SubmissionRule.php
@@ -39,26 +39,26 @@ abstract class SubmissionRule implements ValidationRule, ValidatorAwareRule
      */
     public function setValidator(Validator $validator): self
     {
-        /** @var UploadedFile|array $files */
-        $files = Arr::get($validator->getData(), 'file');
-
-        foreach ($files as $file) {
-            /** @var UploadedFile $file*/
-
-            $ffprobeData = Arr::get($validator->getData(), 'ffprobeData');
-            if ($ffprobeData === null && $file !== null) {
-                $ffprobeData = $this->getFFprobeData($file);
-                $validator->setValue('ffprobeData', $ffprobeData);
-            }
-            static::$ffprobeData = $ffprobeData;
-
-            $loudnessStats = Arr::get($validator->getData(), 'loudnessStats');
-            if ($loudnessStats === null && $file !== null) {
-                $loudnessStats = $this->getLoudnessStats($file);
-                $validator->setValue('loudnessStats', $loudnessStats);
-            }
-            $this->loudnessStats = $loudnessStats;
+        /** @var UploadedFile|array $file */
+        $file = Arr::get($validator->getData(), 'file');
+
+        if (is_array($file)) {
+            $file = Arr::first($file);
+        }
+
+        $ffprobeData = Arr::get($validator->getData(), 'ffprobeData');
+        if ($ffprobeData === null && $file !== null) {
+            $ffprobeData = $this->getFFprobeData($file);
+            $validator->setValue('ffprobeData', $ffprobeData);
+        }
+        static::$ffprobeData = $ffprobeData;
+
+        $loudnessStats = Arr::get($validator->getData(), 'loudnessStats');
+        if ($loudnessStats === null && $file !== null) {
+            $loudnessStats = $this->getLoudnessStats($file);
+            $validator->setValue('loudnessStats', $loudnessStats);
         }
+        $this->loudnessStats = $loudnessStats;
 
         return $this;
     }