Merge branch 'main' into chore/fix-flaky-optional-tag-suggestion-dial…

…og-test

ankihub/gui/menu.py

@@ -192,6 +192,18 @@ def _create_collaborative_deck_setup(parent: QMenu):
     parent.addAction(q_action)
 
 
+def _confirm_sign_out():
+    confirm = ask_user(
+        "Are you sure you want to Sign out?",
+        yes_button_label="Sign Out",
+        no_button_label="Cancel",
+    )
+    if not confirm:
+        return
+
+    _sign_out_action()
+
+
 def _sign_out_action():
     try:
         AnkiHubClient().signout()
@@ -459,7 +471,7 @@ def _trigger_install_release_version():
 
 def _ankihub_logout_setup(parent: QMenu):
     q_action = QAction("🔑 Sign out", aqt.mw)
-    qconnect(q_action.triggered, _sign_out_action)
+    qconnect(q_action.triggered, _confirm_sign_out)
     parent.addAction(q_action)
 
 

requirements/dev.txt

@@ -17,6 +17,7 @@ vcrpy==4.2.0
 pytest-vcr==1.0.2
 pytest-qt==4.2.0
 pytest-split==0.8.1
+pytest-mock==3.12.0
 factory-boy==3.2.1
 types-factory-boy==0.3.1
 pytest-xvfb==2.0.0

tests/addon/conftest.py

@@ -20,7 +20,6 @@
     install_ah_deck,
     mock_all_feature_flags_to_default_values,
     mock_download_and_install_deck_dependencies,
-    mock_function,
     mock_message_box_with_cb,
     mock_show_dialog_with_cb,
     mock_study_deck_dialog_with_cb,

tests/addon/performance/test_exporting.py

@@ -58,4 +58,4 @@ def export_notes():
 
         duration = profile(export_notes)
         print(f"Exporting {len(notes)} notes took {duration} seconds")
-        assert duration < 0.1
+        assert duration < 0.2