Chore/update release action etc (#948)

* Don't use bot users.

* Copy tweak and to-dos.

* Bump versions.

* Rename token.

.github/workflows/create_release.yml

@@ -14,11 +14,11 @@ jobs:
         with:
           submodules: recursive
           fetch-depth: 0
-          token: ${{ secrets.GH_BOT_ACCESS_TOKEN }}
+          token: ${{ secrets.WORKFLOW_GIT_ACCESS_TOKEN }}
 
       - name: Check status of the last run of the test workflow
         run: |
-          gh auth login --with-token <<< "${{ secrets.GH_BOT_ACCESS_TOKEN }}"
+          gh auth login --with-token <<< "${{ secrets.WORKFLOW_GIT_ACCESS_TOKEN }}"
 
           conclusion=$(gh run list \
             --workflow=ci.yml \
@@ -36,11 +36,6 @@ jobs:
             exit 1
           fi
 
-      - name: Setup git config
-        run: |
-          git config user.name "ankihub-addon-bot"
-          git config user.email "[email protected]"
-
       - name: Setup Python
         uses: actions/setup-python@v4
         with:
@@ -63,6 +58,8 @@ jobs:
 
       - name: Commit version bump and create tag
         run: |
+          git config --global user.name gh
+          git config --global user.email "[email protected]"
           git commit --allow-empty -m "Bump Version to ${{ steps.vars.outputs.version }}"
           git push origin main
           git tag ${{ steps.vars.outputs.version }}

ankihub/gui/operations/deck_creation.py

@@ -68,8 +68,7 @@ def _on_deck_selected(study_deck: StudyDeck) -> None:
 
     public = ask_user(
         "Would you like to make this deck public?<br><br>"
-        'If you chose "No" it will be private and only people with a link '
-        "will be able to see it on the AnkiHub website.",
+        'If you choose "No" your deck will be private and only available to users you invite.',
         show_cancel_button=True,
     )
     if public is None:
@@ -90,6 +89,7 @@ def _on_deck_selected(study_deck: StudyDeck) -> None:
         if add_subdeck_tags is None:
             return  # pragma: no cover
 
+    # TODO Remove this confirmation. We should have a single confirmation that includes all necessary info.
     confirm = ask_user(
         "Uploading the deck to AnkiHub requires modifying notes and note types in "
         f"<b>{deck_name}</b> and will require a full sync afterwards. Would you like to "
@@ -99,6 +99,7 @@ def _on_deck_selected(study_deck: StudyDeck) -> None:
     if not confirm:
         return  # pragma: no cover
 
+    # TODO let's get their confirmation about this in the first dialogue with a checkbox.
     should_upload_media = ask_user(
         "Do you want to upload media for this deck as well? "
         "This will take some extra time but it is required to display images "

requirements/base.txt

@@ -1,2 +1,2 @@
-anki==23.10
-aqt[qt5]==23.10
+anki==24.4.1
+aqt[qt6]==24.4.1