Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUILD-831] feat: Add empty state view to mh integration #1041

Merged
merged 5 commits into from
Nov 27, 2024
Merged

[BUILD-831] feat: Add empty state view to mh integration #1041

merged 5 commits into from
Nov 27, 2024

Conversation

pedroven
Copy link
Collaborator

@pedroven pedroven commented Nov 26, 2024 •
edited by jira bot
Loading

Related issues

Proposed changes

This PR makes these changes:

  • Add the empty state page
  • Add the logic to render the empty state page when the url_list is empty
  • Update the style of the header and add dark mode style

How to reproduce

  1. Pass an empty url_list to SplitScreenWebViewManager
  2. Click on one of the buttons "Boards & beyond" or "First Aid Forward"

Screenshots and videos

image
image

@pedroven pedroven marked this pull request as ready for review November 26, 2024 16:29
@pedroven pedroven requested a review from a team November 26, 2024 16:29
RisingOrange
RisingOrange approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@RisingOrange RisingOrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to update this once a decision is made about the new design for the empty state view.

@RisingOrange RisingOrange merged commit 059c811 into main Nov 27, 2024
7 checks passed
@RisingOrange RisingOrange deleted the BUILD-831 branch November 27, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RisingOrange RisingOrange RisingOrange approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedroven @RisingOrange