[BUILD-974] feat: Add config options for MH steps #1076
Merged
+173
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RisingOrange
changed the title
abdnh
previously approved these changes
Jan 15, 2025
| @@ -3055,62 +3059,80 @@ def test_send_daily_review_summaries_without_data(mocker): | |||
| mock_anki_hub_client.send_daily_card_review_summaries.assert_not_called() | |||
|
|
|||
|
|
|||
| def url_mh_integrations_preview(slug: str) -> str: | |||
There was a problem hiding this comment.
Can we use settings.url_mh_integrations_preview() instead of this?
There was a problem hiding this comment.
No, because the config.app_url is not initialized when the parametrization data is initialized. I'll add a comment
ankihub/gui/config_dialog.py
Outdated
|
|
||
| def update_main_checkbox() -> None: | ||
| main_checkbox.blockSignals(True) | ||
| main_checkbox.setChecked( |
There was a problem hiding this comment.
Maybe we can set Qt.CheckState.PartiallyChecked if only one step is enabled?
abdnh
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to allow users to select for which USMLE step they want to see BB/FA resources in the sidebar.
Related issues
https://ankihub.atlassian.net/jira/software/c/projects/BUILD/boards/1?selectedIssue=BUILD-914
Proposed changes
How to reproduce
Screenshot