Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD-982] feat: Update sidebar immediately when config options change #1078

Merged

Conversation

RisingOrange
Copy link
Collaborator

@RisingOrange RisingOrange commented Jan 16, 2025

We want the sidebar-related config options to immediately take effect when the config dialog is closed.

Related issues

https://ankihub.atlassian.net/jira/software/c/projects/BUILD/boards/1?selectedIssue=BUILD-982

Proposed changes

  • Refactor how button visibility is handled
  • Update sidebar on config close

Screenshots and videos

2025-01-16.16-04-56.mp4

@RisingOrange RisingOrange requested a review from a team January 16, 2025 15:46
Copy link
Collaborator

@cjasm cjasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RisingOrange RisingOrange merged commit 4fadee4 into main Jan 16, 2025
7 checks passed
@RisingOrange RisingOrange deleted the feat/update-sidebar-immediately-when-config-options-change branch January 16, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants