Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the ChangesRequireFullSyncDialog #1109

Open
wants to merge 8 commits into
base: feature/note-type-create-update
Choose a base branch
from

Conversation

RisingOrange
Copy link
Collaborator

@RisingOrange RisingOrange commented Feb 27, 2025

Fixes some issues with the ChangesRequireFullSyncDialog identified during QA: https://ankihub.atlassian.net/jira/software/c/projects/BUILD/boards/1?selectedIssue=BUILD-1041

Related issues

https://ankihub.atlassian.net/jira/software/c/projects/BUILD/boards/1?selectedIssue=BUILD-1041

Proposed changes

  • Fix checkbox not working on some Qt versions
  • Use other arrow icons
  • Adjust "Note type updates" text color and increase font size
  • Open the dialog using show instead of open to change how the dialog looks on MacOs

How to reproduce

Run this in Anki's debug console:

import aqt
from ankihub.gui.changes_require_full_sync_dialog import ChangesRequireFullSyncDialog, ChangesRequireFullSyncError

mid = aqt.mw.col.models.all_names_and_ids()[0].id
error = ChangesRequireFullSyncError(set([mid]))
dialog = ChangesRequireFullSyncDialog(error, parent=aqt.mw)
dialog.show()

Screenshots

@RisingOrange RisingOrange changed the title feat: Adjust the ChangesRequireFullSyncDialog Adjust the ChangesRequireFullSyncDialog Feb 27, 2025
@RisingOrange RisingOrange requested a review from a team February 28, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant