-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make suspension settings into per-deck options #779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed some issues when I was testing this PR:
- if I unsubscribe from the addon the deck will not appear anymore in the list of subscribed decks even if I subscribe to the same deck again, is that intended? Update: After I click in sync, the deck appeared again
- The default option is set to "Always" instead of ”Suspend new cards of new notes”
- When I change the option from "Always" to "Never" and then open "Deck Management" again the option selected remains as "Always"
This is because only installed decks are showed in the list in the Deck Management Dialog now. Previously we were showing all subscribed decks, even if they are not installed. You could sync with AnkiHub to install the deck again and then it would show up in the list.
Good catch! I fixed this now in 289178e. |
759d610
to
efd9a02
Compare
Make the card suspension settings into per-deck options. (Currently they are global options for all deck).
Related issues
Make the card suspension settings per-deck, add them to the new Deck Management dialog
Proposed changes
AnkiHubImporter.import_ankihub_deck
to pass in the new arguments for the suspension options.How to reproduce
On the main Anki window, open the AnkiHub menu and click on
Deck Management
to reach the dialog shown below.Screenshots and videos