chore: Fix background tasks blocking UI

[RisingOrange]

Anki 23.10 serializes background tasks by default and uses_collection=False needs to be specified in order to allow the task to be run in parallel with other tasks (by Anki's task manager which is defined in aqt.mw.taskman).

The add-on is using aqt.taskman.TaskManager.run_in_background in multiple places to start background tasks. Due to the changes introduced in Anki 23.10 some background tasks can now block the UI.
For example, when the media sync is in progress and then the user selects a deck on the Anki main window, a progress dialog opens and blocks the UI like this until the media sync is done:

This is because Anki calls set_current_deck() as a CollectionOp in the background and set_current_deck can’t be run until the media sync is done.

To fix this, we can specify uses_collection=False for these background tasks so that the task manager (aqt.mw.taskman) runs the task in parallel with other tasks. We can do this for all tasks that don't use the Anki collection.

Related issues

• Fix background tasks blocking UI
• Report about the issue by @abdnh: https://community.ankihub.net/t/a-progress-dialog-is-shown-for-background-operations-such-as-media-syncing-in-anki-23-10-beta/8314

Proposed changes

• Add ankihub.gui.operations.AddonQueryOp. This is a subclass of aqt.operations.QueryOp which is adapted for usage in the AnkiHub add-on. QueryOp is a helper class to perform an operation on a background thread. It uses aqt.taskman.TaskManager.run_in_background internally. See https://github.com/ankitects/anki/blob/ae6a03942f651790c40f8d8479f90eb7715bf2af/qt/aqt/operations/__init__.py#L167-L168. The main reason for creating this subclass, instead of just using QueryOp, is this:
  https://github.com/ankipalace/ankihub_addon/blob/4e5526aca819ca50eedf7987244804ceccff2a51/ankihub/gui/operations/__init__.py#L16-L27
• Replace usages of aqt.mw.taskman.run_in_background with AddonQueryOp.
  For example this:
  https://github.com/ankipalace/ankihub_addon/blob/798e5520bd97d30f33285f31054fb75b4355c51a/ankihub/gui/media_sync.py#L47-L50
  gets replaced with this:
  https://github.com/ankipalace/ankihub_addon/blob/4e5526aca819ca50eedf7987244804ceccff2a51/ankihub/gui/media_sync.py#L51-L55
• Add tests

[codecov]

Codecov Report

Merging #797 (2b78b8c) into main (c1e76c8) will increase coverage by 0.46%.
The diff coverage is 97.67%.

@@            Coverage Diff             @@
##             main     #797      +/-   ##
==========================================
+ Coverage   81.94%   82.41%   +0.46%     
==========================================
  Files          64       65       +1     
  Lines        5743     5754      +11     
==========================================
+ Hits         4706     4742      +36     
+ Misses       1037     1012      -25     

Files	Coverage Δ
ankihub/gui/errors.py	54.78% <100.00%> (+8.54%)	⬆️
ankihub/gui/media_sync.py	95.09% <100.00%> (+0.20%)	⬆️
ankihub/gui/menu.py	46.81% <100.00%> (+0.17%)	⬆️
ankihub/gui/operations/deck_creation.py	80.00% <100.00%> (ø)
ankihub/gui/optional_tag_suggestion_dialog.py	83.01% <100.00%> (+0.16%)	⬆️
ankihub/gui/operations/__init__.py	91.66% <91.66%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

[pedroven]

🌱 Since this is a value used in multiple places, maybe is a good idea to store this in a constant that can be imported by different modules.

[RisingOrange]

@pedroven
What do you mean? ANKI_MINOR is already a constant (which is defined in ankihub.settings.

Here's a related PR, which renames the constant to ANKI_INT_VERSION make the name more accurate btw: #805

[pedroven]

I wasn't talking about the ANKI_MINOR, I'm talking about the value 231000. This value is kind of a magic number, without context is almost impossible to know why this value is important. So I'm suggesting changing this value to a constant that adds some context.

[RisingOrange]

@pedroven Oh that makes sense! Created a PR for it: #806