feat: Add more fields to CardReviewData
#798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace/ankihub_addon into feat/add-more-review-data-fields
Codecov Report
@@ Coverage Diff @@
## main #798 +/- ##
==========================================
+ Coverage 81.81% 81.83% +0.01%
==========================================
Files 64 64
Lines 5737 5743 +6
==========================================
+ Hits 4694 4700 +6
Misses 1043 1043
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
heitorado
reviewed
Nov 9, 2023
| """ | ||
| SELECT MAX(r.id) | ||
| SELECT MIN(r.id), MAX(r.id) |
There was a problem hiding this comment.
I really like how this was built in a way that the change to get the new data was really simple! 💯
heitorado
reviewed
Nov 9, 2023
Comment on lines
+30
to
+32
| total_card_reviews_last_7_days = _get_review_count_for_ah_deck_since( | ||
| ah_did, now - timedelta(days=7) | ||
| ) |
There was a problem hiding this comment.
Awesome, really nice that you could reuse this method! 💯
heitorado
approved these changes
Nov 9, 2023
RisingOrange
added a commit
that referenced
this pull request
Nov 10, 2023
* Add fields to `CardReviewData` * Get field values from db and add them to review data * Begin updating tests * Change log message * fixup get_first_and_last * Update tests * Add comment * Remove newline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
total_card_reviews_last_7_daysandfirst_card_review_atfields toCardReviewDataand adds the logic to get the values for these fields.Related issues
Proposed changes
total_card_reviews_last_7_daysandfirst_card_review_atfields toankihub.ankihub_client.models.CardReviewDataankihub.main.review_datato get the values for the fields and set them on theCardReviewDataobjects sent to the API