Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deck creation UI on Anki qt6 on MacOS #799

Merged
merged 4 commits into from
Nov 11, 2023

Conversation

RisingOrange
Copy link
Collaborator

@RisingOrange RisingOrange commented Nov 9, 2023

On Anki versions higher than 2.1.66 on Qt6 it’s not possible to create an AnkiHub deck. When the user selects a deck and confirms, nothing happens.
The forum post linked below includes a video that shows when the problem happens.

This PR attempts to fix this problem.

Related issues

Fix UI for creating deck on Anki ≥ 21.66 Qt6
Report on the forum: https://community.ankihub.net/t/cant-upload-new-collaborative-decks-on-qt6/2340

Proposed changes

How to reproduce

The bug was reported by users who were using the Qt6 version of Anki >= 2.1.60 on MacOS.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #799 (2f8c738) into main (545809a) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 2f8c738 differs from pull request most recent head d5cfec5. Consider uploading reports for the commit d5cfec5 to get more accurate results

@@           Coverage Diff           @@
##             main     #799   +/-   ##
=======================================
  Coverage   81.94%   81.94%           
=======================================
  Files          64       64           
  Lines        5743     5743           
=======================================
  Hits         4706     4706           
  Misses       1037     1037           
Files Coverage Δ
ankihub/gui/operations/deck_creation.py 80.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@RisingOrange RisingOrange marked this pull request as ready for review November 9, 2023 23:53
@RisingOrange RisingOrange requested a review from abdnh November 9, 2023 23:54
@RisingOrange RisingOrange merged commit c1e76c8 into main Nov 11, 2023
@RisingOrange RisingOrange deleted the fix/deck-creation-ui-macos-qt6 branch November 11, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants