Attempt to use mocker and reset os.remove #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RisingOrange
merged commit e93e3c2
into
chore/use-pytest-mock-for-client-tests
6 checks passed
RisingOrange
added a commit
that referenced
this pull request
Dec 30, 2023
* chore: Replaces usages of monkeypatch in test_client.py * Attempt to use mocker and reset os.remove (#850) * Attempt to use mocker and reset os.remove * Use mocker.resetall to reset all mocks * Use stop (reset is just for the mock call values) * Fix types: use mocker.stop on remove_mock --------- Co-authored-by: Trey Hunner <[email protected]>
RisingOrange
added a commit
that referenced
this pull request
Dec 30, 2023
* Add pytest-mock to requirements * chore: Replace usages of monkeypatch in test_unit.py * Replace usages of `mock_function` in test_unit.py with `mocker.patch` * Simplify raising exceptions * Prefeer `mocker.patch` over `mocker.patch.object` * Use mocker.stub() for mocking callbacks * chore: Use pytest-mock in client tests (#848) * chore: Replaces usages of monkeypatch in test_client.py * Attempt to use mocker and reset os.remove (#850) * Attempt to use mocker and reset os.remove * Use mocker.resetall to reset all mocks * Use stop (reset is just for the mock call values) * Fix types: use mocker.stop on remove_mock --------- Co-authored-by: Trey Hunner <[email protected]> * Chore/use pytest mock for integration tests (#849) * Replace some monkeypatch uses with pytest-mock * Use mocker everywhere in integration tests Replace all uses of unittest.mock, monkeypatch fixture, and the custom mock_function fixture with the mocker fixture from pytest-mock. * Use mocker for mock_function fixture * Use non-string type annotations for Mock * Prefer mocker.patch over mocker.patch.object * Apply suggestions from code review Co-authored-by: Jakub Fidler <[email protected]> * Fix variable name typos (mesaage -> message) * Remove unused mock_function fixture --------- Co-authored-by: Jakub Fidler <[email protected]> --------- Co-authored-by: Trey Hunner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix the
os.removeissue noted in PR #848.Merging this will merge into the code for #848.