Players endpoints

app/controllers/events_controller.rb → app/controllers/missions/events_controller.rb

@@ -1,4 +1,4 @@
-class EventsController < ApplicationController
+class Missions::EventsController < ApplicationController
   before_action :restrict_access, only: [:create, :update, :destroy]
   before_action :set_mission
   before_action :set_event, only: [:show, :update, :destroy]

app/controllers/missions/players_controller.rb

@@ -0,0 +1,17 @@
+class Missions::PlayersController < ApplicationController
+  before_action :set_mission
+
+  # GET /missions/:mission_id/players
+  def index
+    @players = @mission.events.select("data #>> '{player, name}' as name, data #>> '{player, uid}' as uid")
+    .where("data #>> '{player, uid}' != 'null'")
+    .group("uid, name")
+
+    render json: @players
+  end
+
+  private
+    def set_mission
+      @mission = Mission.find(params[:mission_id])
+    end
+end

app/controllers/players_controller.rb

@@ -1,17 +1,11 @@
 class PlayersController < ApplicationController
-  before_action :set_mission
 
-  # GET /missions/:mission_id/players
+  # GET /players
   def index
-    @players = @mission.events.select("data #>> '{player, name}' as name, data #>> '{player, uid}' as uid")
+    @players = Event.select("data #>> '{player, name}' as name, data #>> '{player, uid}' as uid")
     .where("data #>> '{player, uid}' != 'null'")
     .group("uid, name")
 
     render json: @players
   end
-
-  private
-    def set_mission
-      @mission = Mission.find(params[:mission_id])
-    end
 end

config/routes.rb

@@ -2,7 +2,11 @@
   # For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html
 
   resources :missions do
-    resources :events
-    resources :players, only: [:index]
+    scope module: :missions do
+      resources :events
+      resources :players, only: [:index]
+    end
   end
+
+  resources :players, only: [:index]
 end

test/controllers/events_controller_test.rb → test/controllers/missions/events_controller_test.rb

@@ -1,6 +1,6 @@
 require 'test_helper'
 
-class EventsControllerTest < ActionDispatch::IntegrationTest
+class Missions::EventsControllerTest < ActionDispatch::IntegrationTest
   setup do
     @event = events(:player_connected)
     @mission = missions(:one)

test/controllers/missions/players_controller_test.rb

@@ -0,0 +1,12 @@
+require 'test_helper'
+
+class Missions::PlayersControllerTest < ActionDispatch::IntegrationTest
+  setup do
+    @mission = missions(:one)
+  end
+
+  test "should get index" do
+    get mission_players_url(@mission)
+    assert_response :success
+  end
+end

test/controllers/players_controller_test.rb

@@ -0,0 +1,8 @@
+require 'test_helper'
+
+class PlayersControllerTest < ActionDispatch::IntegrationTest
+  test "should get index" do
+    get players_url
+    assert_response :success
+  end
+end