Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update appbase which only calls stop_executor_cb once #1075

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Update appbase which only calls stop_executor_cb once #1075

merged 2 commits into from
Dec 18, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Dec 17, 2024

Requires AntelopeIO/appbase#37

#1074 is an instance where quit() was called during shutdown which called stop_executor_cb() which tried to access the controller after it was destroyed.

Resolves #1074

@heifner heifner added the OCI Work exclusive to OCI team label Dec 17, 2024
@heifner heifner requested review from greg7mdp and linh2931 December 17, 2024 19:58
@ericpassmore
Copy link
Contributor

Note:start
category: System Stability
component: Internal
summary: Update appbase which only calls stop_executor_cb once.
Note:end

@heifner heifner merged commit 80c564b into main Dec 18, 2024
36 checks passed
@heifner heifner deleted the GH-1074-exit-core branch December 18, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure: liveness_test
4 participants
@heifner @ericpassmore @greg7mdp @linh2931