Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding linter check for commits #11

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

lucifercr07
Copy link
Contributor

No description provided.

@lucifercr07 lucifercr07 marked this pull request as ready for review June 3, 2024 11:39
@lucifercr07 lucifercr07 force-pushed the lucifercr07/adding_linter_pre_commit_hook branch from 1fd4119 to a59bb8b Compare June 3, 2024 11:45
@lucifercr07 lucifercr07 requested a review from rothoma2 June 3, 2024 11:45
@lucifercr07 lucifercr07 force-pushed the lucifercr07/adding_linter_pre_commit_hook branch 4 times, most recently from 9cb337b to 4e8e98f Compare June 3, 2024 12:42
@rothoma2
Copy link
Contributor

rothoma2 commented Jun 3, 2024

Im fine using a linter but I would rather have us use flake8 and mypu than black. I think this tools are more standard on the opensource community.
Any specific reason why you prefer black over flake8 and mypu?

@lucifercr07 lucifercr07 force-pushed the lucifercr07/adding_linter_pre_commit_hook branch 2 times, most recently from b6bb8b8 to f65bf15 Compare June 3, 2024 14:47
README.md Outdated Show resolved Hide resolved
@click.command(
help="""
Download eitheir hundred recent malwares uploaded within the last 60 min or all the recent malwares uploaded within the last 48 hours sha256 hash by using api from 'https://mb-api.abuse.ch/api/v1/'
Download either hundred recent malware's uploaded within the last 60 min or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This help will likely change once we start adding more backends.
This is very descriptive of Malware Bazaar but keep in mind this tool will likely use 8 or 9 different backends, so we wont be able to go into that much detail for each backend.

@lucifercr07 lucifercr07 force-pushed the lucifercr07/adding_linter_pre_commit_hook branch from f65bf15 to b7c976c Compare June 3, 2024 17:06
@lucifercr07 lucifercr07 merged commit 32322f8 into main Jun 3, 2024
3 checks passed
@lucifercr07 lucifercr07 deleted the lucifercr07/adding_linter_pre_commit_hook branch June 3, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants