Fix tests and reuse winston log message builder #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @AntonNguyen any news on this? |
| options = options || {}; | ||
|
|
||
| this.json = options.json || false; | ||
| this.colorize = options.colorize || false; |
There was a problem hiding this comment.
Since this is always false when logging, we don't need to set it at all.
|
@chris-rock Your stuff looks good. One issue I have is the inconsistent indentation style. Some places we have 2 spaces, others we have 4 spaces. I was following this style guide, so it'd be great if you switched to 2 spaces. 😄 |
|
Hey @AntonNguyen Just updated everything to 2-spaces and fixed the settings for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
winston/lib/winston/common