Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better range visualisation #5968

Closed

Conversation

MEEPofFaith
Copy link
Contributor

I've redone #4821, which fixes merge conflicts and might be better(?).
Honestly, I don't really know what the differences between this and the original are.

Placement.mp4
Fadeaway.mp4

If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:

  • I have read the contribution guidelines.
  • I have ensured that my code compiles, if applicable.
  • I have ensured that any new features in this PR function correctly in-game, if applicable.

@katastic
Copy link

This is supposed to be an improvement but I can't tell what's even going on. Why are there two radii? The old vs the new? Or are there two radii for two different purposes?

@MEEPofFaith
Copy link
Contributor Author

MEEPofFaith commented Sep 10, 2021

This is supposed to be an improvement but I can't tell what's even going on. Why are there two radii? The old vs the new? Or are there two radii for two different purposes?

The inner range is what the block normally has, the outer range is when it is boosted.
Like when you put phase fabric into a mend projector/overdrive projector/shield projector

@MEEPofFaith
Copy link
Contributor Author

Watch the second video.

@SoMall-dumpling
Copy link
Contributor

Why isn’t the force projector’s range showed as dotted line? Change it pls.
Others are really great. It is very useful when arranging mend/overdrive projectors with phase fabric.

@MEEPofFaith
Copy link
Contributor Author

Why isn’t the force projector’s range showed as dotted line? Change it pls.
Others are really great. It is very useful when arranging mend/overdrive projectors with phase fabric.

Because it normally doesn't have a dotted line?

@SoMall-dumpling
Copy link
Contributor

Because it normally doesn't have a dotted line?

I just wonder why Anuken didn't give it dotted line at first.

@MEEPofFaith
Copy link
Contributor Author

Because it normally doesn't have a dotted line?

I just wonder why Anuken didn't give it dotted line at first.

Consider how the lines are drawn.

@MEEPofFaith
Copy link
Contributor Author

It's been 84 years

@MEEPofFaith
Copy link
Contributor Author

Given the conversation in #pulls, I don't imagine this pr in particular being merged.
That being said, some way of being able to see the boosted range while placing down projector would be nice qol, I just don't know how to implement it in a way that can't be confused.

@MEEPofFaith MEEPofFaith deleted the Better-Range-Visualisation branch February 10, 2025 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants