Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision of impala regression tests #57

Merged
merged 45 commits into from
Feb 28, 2019
Merged

Revision of impala regression tests #57

merged 45 commits into from
Feb 28, 2019

Conversation

stlemme
Copy link
Member

@stlemme stlemme commented Mar 14, 2017

  • new cmake option Impala_ENABLE_TESTS (default OFF)
  • new library target rtmock, which is the fake runtime (still issues on win32 due to posix)
  • intermediate output of tests are placed in build folder not polluting the source tree
$ cd impala/build
$ ctest -C Release -R codegen
64% tests passed, 42 tests failed out of 116

@stlemme
Copy link
Member Author

stlemme commented Mar 14, 2017

This addresses #51 but still requires additional work.

  • mark broken codegen tests
  • freeze output of tests where appropriate
  • fix issues in rtmock (linking, required set of functions)
  • add support for further test methods (i.e. sema)

@stlemme stlemme requested a review from leissa March 20, 2017 10:05
@stlemme
Copy link
Member Author

stlemme commented Mar 20, 2017

Using the test script without ctest boils down to

cd impala/test
python3 perform.py --libc ../build/lib/librtmock.a codegen/ackermann.impala

if impala as well as clang is in PATH
Then it behaves like the old one and outputs the logs into current working directory.

leissa added a commit that referenced this pull request Mar 21, 2017
* mark broken tests
@stlemme stlemme merged commit f3ca3c2 into master Feb 28, 2019
@stlemme stlemme deleted the ctest branch April 8, 2019 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants