Remove rv_all from gpu generated code
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should probably have some kind of generic portable SIMD intrinsics that work regardless of the platform (RV, CUDA, AMDHSA, OpenCL, Shady...) |
|
Yes I agree. We should also include the "fma" instruction to the math builtins (maybe with a fallback for non LLVM, e.g, OpenCL, etc). I think there are more general purpose intrinsic which might be handy on all systems - if a well-behaving fallback can be defined. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GPU kernels get polluted by the
rv_allinstruction. The instruction will be filtered out only if Thorin is compiled with RV. This might not happen, as we should not expect RV to be available when Rodent is used only for GPU.The "fix" is quite simple and it would be great to get rid of the code duplication, but that is beyond the task of this simple PR.