chore: fix 404 status URL #2440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: linchizhen <[email protected]>
|
Which URL? Having a trouble finding it in the diff.. These are compiled artifacts tied to specific versions of OpenZeppelin, a bad URL is probably meant to be if it is in a published contract anyway. Can you tell me more what brings this change? |
|
This PR made me realize though, we should be using Ape's dependency system here and not hardcoding massive OZ files. If you want to work on this, we will support you. Basically, delete these files and update the ape-config to use the different OpenZeppelin versions as dependency and update any tests accordingly. That would be extremely helpful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fix 404 status URL
How I did it
How to verify it
Checklist