Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: change default test chain ID to match foundry's #2460

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Jan 6, 2025

What I did

fixes: #2454

How I did it

How to verify it

Checklist

  • All changes are completed
  • Change is covered in tests
  • Documentation is complete

Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be considered a breaking change to stage for v0.9?

@antazoey
Copy link
Member Author

antazoey commented Jan 6, 2025

Would this be considered a breaking change to stage for v0.9?

Yes that is why it is targeting the feat/09 branch. But i forget the exclamation point in the or title. Ill add

@antazoey antazoey changed the title refactor: change default test chain ID to match foundry's refactor!: change default test chain ID to match foundry's Jan 7, 2025
@antazoey antazoey merged commit 0547d74 into ApeWorX:feat/0-9 Jan 7, 2025
17 checks passed
@antazoey antazoey deleted the refactor/chainid-default branch January 7, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants