feat: pep-625 compliance, enabling python 3.13, and import perfs #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
reviewed
Dec 16, 2024
antazoey
approved these changes
Dec 16, 2024
antazoey
reviewed
Dec 16, 2024
| from evmchains.chains import PUBLIC_CHAIN_META | ||
| from evmchains.types import Chain | ||
| if TYPE_CHECKING: | ||
| from evmchains.types import Chain | ||
|
|
||
| ENV_VAR_REGEX = re.compile(r"\$\{([A-Za-z0-9_]+)\}") |
There was a problem hiding this comment.
I wonder if we should hold off on compiling the regex as well? Potentially doing
ENV_VAR_REGEX = r"\$\{([A-Za-z0-9_]+)\}"
would suffice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixes: APE-1853
Fixes: APE-1860
How I did it
How to verify it
Checklist