Bump ruby versions on test jobs #927
Conversation
Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
|
I have never seen this before in a Gemfile: Line 8 in f300fcc Reading https://bundler.io/v2.5/man/gemfile.5.html#RUBY I don't really see the point of this. There is already a declaration for compatible versions here: apipie-rails/apipie-rails.gemspec Line 14 in f300fcc So I'd propose to drop that line from the Gemfile. |
| @@ -5,7 +5,6 @@ source 'https://rubygems.org' | |||
| gemspec path: '.' | |||
|
|
|||
| # use ENV vars, with default value as fallback for local setup | |||
| ruby(ENV['RUBY_VERSION'] || '3.2.2') | |||
There was a problem hiding this comment.
I guess for a gem it is not as useful as for an app. but this ensure the app runs on the ruby it is supposed to.
people running in docker its usually not a problem, but systems with multiple ruby, bundler will complain if the ruby does not have the right version.
I don't have an objection if you prefer removing it.
There was a problem hiding this comment.
Indeed, for an app that doesn't have a gemspec it can make sense but for a gem I don't see the point.
There was a problem hiding this comment.
in a way, it was adding a guarantee that GHA, indeed, runs the test with the correct ruby version.
I don't remember if this project is one of the first that I moved from multiple Gemfiles to a single. but it might be the reason.
|
@ekohl I've been doing squash merge for a few years now, I think we should stick with squash merge on this projct. |
Use latest ruby versions on test jobs