-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added readonly
modifier to private fields which are never changed
#1451
Conversation
Thanks for your contribution. As you can see, the build is now failing due to readonly being incompatible with other uses of these fields in the code. It may be that all of these fields are already not readonly for that very reason. Please run the build locally and fix any issues to continue with this contribution. |
You are absolutely right. I managed to reproduce the errors in my local environment, and removed the problematic |
The changes are now hitting lint errors. Please get a full clean build locally before pushing further changes. |
No problem. I planned to fix the linting issues in a future PR, but I didn't have any idea that they were configured to make a build fail. It's understandable, of course. You want to keep the code clean. The built succeeded in my machine without errors or warnings. |
Codecov Report
@@ Coverage Diff @@
## main #1451 +/- ##
=======================================
Coverage 83.90% 83.90%
=======================================
Files 273 273
Lines 6516 6516
Branches 1012 1012
=======================================
Hits 5467 5467
Misses 840 840
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Thanks! |
Confirm the following