Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use StrategyHelper for safe executions and drop redundant methods #1463

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Aug 8, 2023

Details on the issue fix or feature implementation

Just some minor cleanup of internal APIs.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Aug 8, 2023
@martintmk martintmk added this to the v8.0.0 milestone Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #1463 (c3941d7) into main (4153d2a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1463      +/-   ##
==========================================
- Coverage   83.89%   83.89%   -0.01%     
==========================================
  Files         276      275       -1     
  Lines        6495     6493       -2     
  Branches     1015     1015              
==========================================
- Hits         5449     5447       -2     
  Misses        837      837              
  Partials      209      209              
Flag Coverage Δ
linux ?
macos 83.89% <100.00%> (?)
windows 83.89% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Polly.Core/ResilienceStrategy.cs 100.00% <ø> (ø)
...CircuitBreaker/CircuitBreakerResilienceStrategy.cs 100.00% <100.00%> (ø)
.../Polly.Core/Fallback/FallbackResilienceStrategy.cs 100.00% <100.00%> (ø)
src/Polly.Core/Retry/RetryResilienceStrategy.cs 100.00% <100.00%> (ø)
...rc/Polly.Core/Timeout/TimeoutResilienceStrategy.cs 100.00% <100.00%> (ø)

@martintmk martintmk enabled auto-merge (squash) August 8, 2023 11:33
@martintmk martintmk merged commit 5ad71b7 into main Aug 8, 2023
12 checks passed
@martintmk martintmk deleted the mtomka/use-strategyhelper branch August 8, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants