Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide/drop some unused APIs #1491

Merged
merged 4 commits into from
Aug 16, 2023
Merged

Hide/drop some unused APIs #1491

merged 4 commits into from
Aug 16, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Aug 16, 2023

Details on the issue fix or feature implementation

Just going through the APIs and trimming some fat. All these are easy to add back of there is a need for it.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Aug 16, 2023
@martintmk martintmk added this to the v8.0.0 milestone Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #1491 (487a611) into main (9fd37be) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1491      +/-   ##
==========================================
- Coverage   83.71%   83.63%   -0.09%     
==========================================
  Files         272      272              
  Lines        6424     6390      -34     
  Branches     1012     1010       -2     
==========================================
- Hits         5378     5344      -34     
  Misses        837      837              
  Partials      209      209              
Flag Coverage Δ
linux 83.63% <100.00%> (-0.09%) ⬇️
macos 83.63% <100.00%> (-0.09%) ⬇️
windows 83.63% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...Core/Registry/ResiliencePipelineRegistryOptions.cs 100.00% <ø> (ø)
src/Polly.Core/ResiliencePropertyKey.cs 100.00% <ø> (ø)
src/Polly.Core/Telemetry/TelemetryUtil.cs 100.00% <ø> (ø)
...xtensions/Telemetry/ResilienceContextExtensions.cs 100.00% <ø> (ø)
src/Polly.Core/Registry/ConfigureBuilderContext.cs 100.00% <100.00%> (ø)
.../Polly.Core/Registry/ResiliencePipelineRegistry.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResilienceContext.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResiliencePipelineBuilderBase.cs 100.00% <100.00%> (ø)
src/Polly.Core/StrategyBuilderContext.cs 100.00% <100.00%> (ø)
...ependencyInjection/AddResiliencePipelineContext.cs 100.00% <100.00%> (ø)
... and 1 more

@martintmk martintmk enabled auto-merge (squash) August 16, 2023 05:49
@martintmk martintmk enabled auto-merge (squash) August 16, 2023 06:03
@martintmk martintmk merged commit 1d16fd7 into main Aug 16, 2023
16 checks passed
@martintmk martintmk deleted the mtomka/cleanup-apis branch August 16, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants