Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide IsSynchronous property #1494

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Hide IsSynchronous property #1494

merged 1 commit into from
Aug 16, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Aug 16, 2023

Details on the issue fix or feature implementation

The property is only used internally and if someone really needs it, we can unhide it later.

Contributes to #1233 (comment)

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Aug 16, 2023
@martintmk martintmk added this to the v8.0.0 milestone Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #1494 (d12db92) into main (1358076) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1494   +/-   ##
=======================================
  Coverage   83.64%   83.64%           
=======================================
  Files         268      268           
  Lines        6394     6394           
  Branches     1007     1007           
=======================================
  Hits         5348     5348           
  Misses        837      837           
  Partials      209      209           
Flag Coverage Δ
linux 83.64% <100.00%> (ø)
macos 83.64% <100.00%> (?)
windows 83.64% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Polly.Core/ResilienceContext.cs 100.00% <100.00%> (ø)

@martintmk martintmk merged commit 57c540d into main Aug 16, 2023
16 checks passed
@martintmk martintmk deleted the mtomka/hide-IsSynchronous branch August 16, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants