Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SA1501/IDE0055 #1957

Merged
merged 3 commits into from
Feb 16, 2024

Improve unit test coverage

8df1a25
Select commit
Loading
Failed to load commit list.
Merged

Fix SA1501/IDE0055 #1957

Improve unit test coverage
8df1a25
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 16, 2024 in 1s

83.23% (-2.67%) compared to b194abf

View this Pull Request on Codecov

83.23% (-2.67%) compared to b194abf

Details

Codecov Report

Attention: 569 lines in your changes are missing coverage. Please review.

Comparison is base (b194abf) 85.90% compared to head (8df1a25) 83.23%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/Polly/Retry/AsyncRetryTResultSyntax.cs 9.43% 48 Missing and 48 partials ⚠️
src/Polly/Retry/AsyncRetrySyntax.cs 20.90% 43 Missing and 44 partials ⚠️
src/Polly/Retry/RetryTResultSyntax.cs 11.76% 30 Missing and 30 partials ⚠️
src/Polly/Caching/AsyncCacheTResultSyntax.cs 11.11% 16 Missing and 16 partials ⚠️
src/Polly/Caching/CacheTResultSyntax.cs 11.11% 16 Missing and 16 partials ⚠️
src/Polly/Retry/RetrySyntax.cs 60.52% 15 Missing and 15 partials ⚠️
src/Polly/Timeout/AsyncTimeoutTResultSyntax.cs 30.00% 10 Missing and 11 partials ⚠️
src/Polly/Context.Dictionary.cs 9.09% 20 Missing ⚠️
src/Polly/Caching/AsyncCacheSyntax.cs 25.00% 9 Missing and 9 partials ⚠️
src/Polly/Caching/CacheSyntax.cs 25.00% 9 Missing and 9 partials ⚠️
... and 17 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1957      +/-   ##
==========================================
- Coverage   85.90%   83.23%   -2.67%     
==========================================
  Files         312      312              
  Lines        6647     7106     +459     
  Branches     1056     1056              
==========================================
+ Hits         5710     5915     +205     
- Misses        540      806     +266     
+ Partials      397      385      -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov