Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CA1062 warning. Composite(Draft) #2176

Conversation

Zombach
Copy link
Contributor

@Zombach Zombach commented Jul 4, 2024

Pull Request

The issue or feature being addressed

#1290

Details on the issue fix or feature implementation

  • Suppress CA1062 in the code or fix the warning

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

I will conditionally divide the partitions by directory names

@Zombach Zombach marked this pull request as draft July 4, 2024 11:19
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 48.31461% with 92 lines in your changes missing coverage. Please review.

Project coverage is 84.36%. Comparing base (1eb48d7) to head (ee4bb01).

Files Patch % Lines
src/Polly/Caching/AsyncCacheTResultSyntax.cs 35.52% 32 Missing and 17 partials ⚠️
src/Polly/Caching/CacheTResultSyntax.cs 48.83% 5 Missing and 17 partials ⚠️
src/Polly/Caching/AsyncCacheSyntax.cs 45.16% 11 Missing and 6 partials ⚠️
src/Polly/Caching/CacheSyntax.cs 82.60% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2176      +/-   ##
==========================================
+ Coverage   83.88%   84.36%   +0.48%     
==========================================
  Files         313      313              
  Lines        7172     7271      +99     
  Branches     1060     1089      +29     
==========================================
+ Hits         6016     6134     +118     
+ Misses        785      776       -9     
+ Partials      371      361      -10     
Flag Coverage Δ
linux 84.36% <48.31%> (+0.48%) ⬆️
macos 84.36% <48.31%> (+0.48%) ⬆️
windows 84.36% <48.31%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zombach Zombach closed this Jul 23, 2024
@Zombach Zombach deleted the zombach/remove-warning-ca1062-validate-arguments-public-methods branch July 23, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant