Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CA1068 warning #2182

Merged
merged 6 commits into from
Jul 8, 2024
Merged

Fix CA1068 warning #2182

merged 6 commits into from
Jul 8, 2024

Conversation

iamdmitrij
Copy link
Contributor

Pull Request

The issue or feature being addressed

#1290

Details on the issue fix or feature implementation

For public interfaces, pragma suppression was used. For non-public code, refactored code to make CancellationToken last param.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 94.80519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.80%. Comparing base (c93aeff) to head (7f88f8f).

Files Patch % Lines
src/Polly/Wrap/AsyncPolicyWrap.cs 83.33% 2 Missing ⚠️
src/Polly/Wrap/PolicyWrap.cs 83.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2182   +/-   ##
=======================================
  Coverage   83.80%   83.80%           
=======================================
  Files         313      313           
  Lines        7161     7162    +1     
  Branches     1060     1060           
=======================================
+ Hits         6001     6002    +1     
  Misses        789      789           
  Partials      371      371           
Flag Coverage Δ
linux 83.80% <94.80%> (+<0.01%) ⬆️
macos 83.80% <94.80%> (+<0.01%) ⬆️
windows 83.80% <94.80%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iamdmitrij iamdmitrij marked this pull request as ready for review July 8, 2024 17:16
@martincostello martincostello merged commit 4f02c66 into App-vNext:main Jul 8, 2024
18 checks passed
@iamdmitrij iamdmitrij deleted the fix-CA1068 branch July 9, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants