Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ide0002 style rule #2302

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

gabidabet
Copy link
Contributor

@gabidabet gabidabet commented Sep 25, 2024

Pull Request

The issue or feature being addressed

It is related to that issue 1290, but that warning was not on the list.

Details on the issue fix or feature implementation

Fix ide0002 style rule in visual studio + rider.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature (Not needed in my case)
  • I have successfully run a local build

@gabidabet
Copy link
Contributor Author

@gabidabet please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.38%. Comparing base (0d925bc) to head (a009ad7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2302   +/-   ##
=======================================
  Coverage   85.38%   85.38%           
=======================================
  Files         313      313           
  Lines        7457     7457           
  Branches     1124     1124           
=======================================
  Hits         6367     6367           
  Misses        745      745           
  Partials      345      345           
Flag Coverage Δ
linux 85.38% <100.00%> (+0.02%) ⬆️
macos 85.38% <100.00%> (ø)
windows 85.38% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello
Copy link
Member

Thanks

@martincostello martincostello enabled auto-merge (squash) September 25, 2024 21:10
@martincostello martincostello merged commit d496e1f into App-vNext:main Sep 25, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants