Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: launch review issues #6479

Merged
merged 5 commits into from
Oct 5, 2024

Conversation

richardshiue
Copy link
Collaborator

@richardshiue richardshiue commented Oct 4, 2024

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Copy link

github-actions bot commented Oct 4, 2024

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports level link
Missing translation 27 warning contribute (via Fink 🐦)

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.16%. Comparing base (7ecf213) to head (138b1d5).
Report is 94 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6479      +/-   ##
==========================================
- Coverage   74.41%   67.16%   -7.25%     
==========================================
  Files         245      237       -8     
  Lines        6566     8312    +1746     
  Branches     1057     1084      +27     
==========================================
+ Hits         4886     5583     +697     
- Misses       1628     2590     +962     
- Partials       52      139      +87     
Flag Coverage Δ
appflowy_web_app 67.16% <ø> (-7.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richardshiue richardshiue merged commit 8e6f051 into AppFlowy-IO:main Oct 5, 2024
18 of 19 checks passed
@richardshiue richardshiue deleted the fix/launch-review branch October 5, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant