Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support 'share link' and 'publish' on mobile #6548

Merged
merged 11 commits into from
Oct 15, 2024

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Oct 15, 2024

Feature Preview

Completed part of #5997

  • support 'share link' on mobile
  • support 'publish' and 'visit site' on mobile
  • support 'unpublish' on mobile
  • tests
showcase.mp4

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.03%. Comparing base (7ecf213) to head (16e6b2a).
Report is 134 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6548      +/-   ##
==========================================
- Coverage   74.41%   65.03%   -9.38%     
==========================================
  Files         245      270      +25     
  Lines        6566    10376    +3810     
  Branches     1057     1406     +349     
==========================================
+ Hits         4886     6748    +1862     
- Misses       1628     3471    +1843     
- Partials       52      157     +105     
Flag Coverage Δ
appflowy_web_app 65.03% <ø> (-9.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 15, 2024

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports level link
Missing translation 81 warning contribute (via Fink 🐦)

@LucasXu0 LucasXu0 force-pushed the share_link_on_mobile branch from b8ac4cc to 63373fd Compare October 15, 2024 02:46
@LucasXu0 LucasXu0 changed the title Share link on mobile feat: support 'share link' and 'publish' on mobile Oct 15, 2024
@LucasXu0 LucasXu0 force-pushed the share_link_on_mobile branch from 6429be3 to 4099212 Compare October 15, 2024 03:58
@LucasXu0 LucasXu0 merged commit 7bc53d7 into AppFlowy-IO:main Oct 15, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant