fix: show default view name #6571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it urgent to merge in 0.7.2? If not, keep it in v0.7.3 |
LucasXu0
reviewed
Oct 21, 2024
Comment on lines
+128
to
+136
| (view) => | ||
| view.id != currentViewId && | ||
| view.name.toLowerCase().contains(search.toLowerCase()) || | ||
| (view.name.isEmpty && search.isEmpty) || | ||
| (view.name.isEmpty && | ||
| LocaleKeys.menuAppHeader_defaultNewPageName | ||
| .tr() | ||
| .toLowerCase() | ||
| .contains(search.toLowerCase())), |
There was a problem hiding this comment.
The filter logic looks a bit complicated. How about abstracting a function and adding some comments?
|
@Xazin I merged this PR into v0.7.2. As for the suggestion, you can improve it in v0.7.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates: #6524
Feature Preview
PR Checklist