Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: turn into issues #6576

Merged
merged 10 commits into from
Oct 18, 2024
Merged

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Oct 17, 2024

Feature Preview

  • selecting the parent should deselect all the child nodes as well.
  • test: selecting the parent should deselect all the child nodes as well.
  • the inline mention style doesn’t support on mobile.
  • test: the inline mention style doesn’t support on mobile.

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@LucasXu0 LucasXu0 force-pushed the fix_option_button_issues branch from 0d28e5f to 3f5e46a Compare October 17, 2024 11:48
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.91%. Comparing base (7ecf213) to head (98305ff).
Report is 153 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6576      +/-   ##
==========================================
- Coverage   74.41%   64.91%   -9.50%     
==========================================
  Files         245      271      +26     
  Lines        6566    10399    +3833     
  Branches     1057     1409     +352     
==========================================
+ Hits         4886     6751    +1865     
- Misses       1628     3491    +1863     
- Partials       52      157     +105     
Flag Coverage Δ
appflowy_web_app 64.91% <ø> (-9.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 force-pushed the fix_option_button_issues branch from cbcd76d to 98305ff Compare October 18, 2024 03:27
@LucasXu0 LucasXu0 merged commit 7b031b2 into AppFlowy-IO:main Oct 18, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant