Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guess updateinformation for GitHub Actions #13

Merged
merged 11 commits into from
Dec 8, 2024
Merged

Conversation

probonopd
Copy link
Member

#7

Compiles, but still needs to be tested for correctness.

#7

Compiles, but still needs to be tested for correctness.
@probonopd probonopd requested a review from TheAssassin June 26, 2023 21:14
@probonopd
Copy link
Member Author

Now it is tested for correctness:

export GITHUB_TOKEN=...
export GITHUB_REPOSITORY=probono/AppImages
export GITHUB_REPOSITORY_OWNER=probono
./squashfs-root/AppRun ./squashfs-root/ -g --runtime-file runtime-x86_64

Guessing update information based on $GITHUB_REPOSITORY=probono/AppImages
gh-releases-zsync|probono|AppImages|latest|appimagetool*-x86_64.AppImage.zsync
Embedding MD5 digest
zsyncmake is available and updateinformation is provided, hence generating zsync file

src/appimagetool.c Show resolved Hide resolved
src/appimagetool.c Show resolved Hide resolved
src/appimagetool.c Outdated Show resolved Hide resolved
src/appimagetool.c Outdated Show resolved Hide resolved
probonopd added 2 commits July 2, 2023 09:20
* github_repository_name regardless of owner_start
* Move comment above if statement
src/appimagetool.c Show resolved Hide resolved
if(zsyncmake_path){
char buf[1024];
// gh-releases-zsync|probono|AppImages|latest|Subsurface-*x86_64.AppImage.zsync
sprintf(buf, "gh-releases-zsync|%s|%s|latest|%s*-%s.AppImage.zsync", github_repository_owner, github_repository_name, app_name_for_filename, arch);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another sprintf.

src/appimagetool.c Outdated Show resolved Hide resolved
@@ -765,9 +765,9 @@ main (int argc, char *argv[])

// if $VERSION is specified, we embed it into the filename
if (version_env != NULL) {
sprintf(dest_path, "%s-%s-%s.AppImage", app_name_for_filename, version_env, arch);
snprintf(dest_path, "%s-%s-%s.AppImage", app_name_for_filename, version_env, arch);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, size missing.

src/appimagetool.c Outdated Show resolved Hide resolved
src/appimagetool.c Outdated Show resolved Hide resolved
@TheAssassin
Copy link
Member

You don't need to fix the world in such a PR. New code should be good, though.

src/appimagetool.c Outdated Show resolved Hide resolved
@TheAssassin
Copy link
Member

I have not seen any major issues any more. But I guess I should run a real world test, too. Will approve once done.

@probonopd probonopd requested a review from TheAssassin July 8, 2023 14:17
Copy link
Member

@TheAssassin TheAssassin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work in the real world, too. Thanks. Feel free to merge.

@probonopd probonopd merged commit d870d4f into main Dec 8, 2024
8 checks passed
@probonopd probonopd deleted the feature-guess-github branch December 8, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants