Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Read default value field option and ensure it matches field type #18

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jasmine-wu-ai
Copy link

@jasmine-wu-ai jasmine-wu-ai commented Jan 17, 2024

Add a field option default_value of type google.protobuf.Value (already done in applied2). Set the default value in the jsonschema if it matches the expected type, if not throw error.

Tests:

  • added a new test
  • unsure how to add an "assertThrows" test to validate that when the type and value don't match there is an error thrown, but did manually test.

@jasmine-wu-ai jasmine-wu-ai changed the title [API] Read default value field option [API] Read default value field option and ensure it matches field type Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant