This should fix the NullPointerException #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dani-Koza-AF
added a commit
that referenced
this pull request
Jan 16, 2025
commit fa71c23 Merge: f420460 4f4ee27 Author: Dani-Koza-AF <[email protected]> Date: Thu Oct 31 15:16:50 2024 +0200 Merge remote-tracking branch 'origin/development' into development commit f420460 Author: Dani Koza <[email protected]> Date: Wed Oct 30 15:50:41 2024 +0200 Releases/6.x.x/6.15.x/6.15.2 rc1 (#358) * fixed the issue with MediationNetwork enums on Android * Added a usage example of the logAdRevenue api for testing. * Fix to the NullPointerException some clients face. * Versioning and change log commit 4f4ee27 Merge: a58a49b 25fb530 Author: Dani Koza <[email protected]> Date: Wed Oct 30 14:47:17 2024 +0200 Merge pull request #357 from AppsFlyerSDK/DELIVERY-63011/fix-android-null-pointer-exception This should fix the NullPointerException commit 25fb530 Author: Dani-Koza-AF <[email protected]> Date: Wed Oct 30 14:26:26 2024 +0200 This should fix the NullPointerException commit a58a49b Merge: 6213341 b85b1a4 Author: Dani-Koza-AF <[email protected]> Date: Mon Oct 28 12:30:10 2024 +0200 Merge remote-tracking branch 'origin/development' into development commit b85b1a4 Merge: 82764a4 6529458 Author: Dani Koza <[email protected]> Date: Mon Oct 28 12:15:32 2024 +0200 Merge pull request #353 from AppsFlyerSDK/dev/DELIVERY-71973/mediation-network-value-fix Fixed the issue with MediationNetwork enums on Android commit 6529458 Author: Dani-Koza-AF <[email protected]> Date: Sun Oct 27 17:47:00 2024 +0200 fixed the issue with MediationNetwork enums on Android - added a usage example of the api for testing. commit 6213341 Merge: 3272d7e 82764a4 Author: Dani-Koza-AF <[email protected]> Date: Wed Sep 4 15:51:28 2024 +0300 Merge pull request #338 from AppsFlyerSDK/releases/6.x.x/6.15.x/6.15.1-rc1 Releases/6.x.x/6.15.x/6.15.1 rc1 commit 82764a4 Merge: 3272d7e 6b76d63 Author: Dani-Koza-AF <[email protected]> Date: Wed Sep 4 15:15:03 2024 +0300 Merge pull request #337 from AppsFlyerSDK/dev/DELIVERY-67805/Update-Plugin-to-v6.15.1 Update plugin to v6.15.1 commit 6b76d63 Author: Dani-Koza-AF <[email protected]> Date: Wed Sep 4 15:13:04 2024 +0300 Added missing info in docs commit e7d4dc6 Author: Dani-Koza-AF <[email protected]> Date: Wed Sep 4 14:17:28 2024 +0300 Added documentation commit 9f90c8e Author: Dani-Koza-AF <[email protected]> Date: Tue Sep 3 17:48:33 2024 +0300 Improvement of Android side impl commit 079ccad Author: Dani-Koza-AF <[email protected]> Date: Tue Sep 3 17:22:48 2024 +0300 iOS side impl - Helper func to get the correct enum properly. - requireNonNullArgumentWithCall to make sure we actually get the arguments. - Lots of null safety checks due to testing failures encountered. commit 4a3a0d6 Author: Dani-Koza-AF <[email protected]> Date: Mon Sep 2 14:48:30 2024 +0300 Android side impl - Flutter didn't like the fact that we pass enums, had to change mediation network to String, handled later on native side. - Added an helper method to ensure null safety, hopefully will be embraced by other method in the future. commit d74054e Author: Dani-Koza-AF <[email protected]> Date: Sun Sep 1 16:43:24 2024 +0300 flutter side impl - New Enum introduced. - New API logAdRevenue. - New AdRevenueData class. - Upgraded Dart SDK versions limits a bit to start from 2.17.0 . commit 3272d7e Merge: 95a4348 248dcf5 Author: liaz-af <[email protected]> Date: Mon Aug 19 22:35:24 2024 +0300 Merge pull request #336 from dori-af/dori/udl-note Deep link UDL - added a note commit 248dcf5 Author: Dori Frost <[email protected]> Date: Sun Aug 18 16:35:07 2024 +0300 Deep link UDL - added a note Per Slack: https://appsflyer.slack.com/archives/C5RDRS58X/p1723186908673099
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Null checks added that suppose to fix the issue some clients face.
The native Android SDK is lifecycle aware, hence when for some reason Flutter Activity is detached then (mMethodChannel is set to null) and the native SDK didn't start yet then AppsFlyerRequestListener() will result an onError callback which will throw NullPointerException.