Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write 0 sized entries in metadata track to ensure sync #286

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

mraduldubey
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #285

Description

Made requested changes

Alternative(s) considered

Other ways did not pan out

Type

Type Choose one: (Bug fix)

Checklist

  • I have read the Contribution Guidelines
  • I have written Unit Tests
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Test Results Linux-CudaT

    1 files  ±0      1 suites  ±0   10m 22s ⏱️ ±0s
385 tests ±0  228 ✔️ ±0  157 💤 ±0  0 ±0 
228 runs  ±0    71 ✔️ ±0  157 💤 ±0  0 ±0 

Results for commit be8ce5e. ± Comparison against base commit 0990cd8.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Test Results Linux_ARM64

    1 files  ±0      1 suites  ±0   10m 59s ⏱️ -1s
408 tests ±0  255 ✔️ ±0  153 💤 ±0  0 ±0 
255 runs  ±0  102 ✔️ ±0  153 💤 ±0  0 ±0 

Results for commit be8ce5e. ± Comparison against base commit 0990cd8.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Test Results Linux

    1 files  ±0      1 suites  ±0   10m 22s ⏱️ -1s
294 tests ±0  226 ✔️ ±0  68 💤 ±0  0 ±0 
226 runs  ±0  158 ✔️ ±0  68 💤 ±0  0 ±0 

Results for commit be8ce5e. ± Comparison against base commit 0990cd8.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Test Results Win-nocuda

    1 files  ±0      1 suites  ±0   10m 38s ⏱️ -6s
290 tests ±0  226 ✔️ ±0  64 💤 ±0  0 ±0 
226 runs  ±0  162 ✔️ ±0  64 💤 ±0  0 ±0 

Results for commit be8ce5e. ± Comparison against base commit 0990cd8.

@github-actions
Copy link

Test Results Windows-cuda

    1 files  ±0      1 suites  ±0   12m 20s ⏱️ -1s
381 tests ±0  287 ✔️ ±0  94 💤 ±0  0 ±0 
287 runs  ±0  193 ✔️ ±0  94 💤 ±0  0 ±0 

Results for commit be8ce5e. ± Comparison against base commit 0990cd8.

@kumaakh kumaakh merged commit 388f1c7 into main Aug 10, 2023
18 of 20 checks passed
@kumaakh kumaakh deleted the mp4WriterSyncFix branch August 10, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mp4writer should ensure sync b/w video and metadata track by adding 0 sized entries in metadata track
2 participants