Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control module pipeline fixes & added control module UTs #388

Merged
merged 8 commits into from
Oct 3, 2024

Conversation

mraduldubey
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #384

Description

Fixed bunch of issues in control module

  1. thread not joining issue
  2. cyclic dependency

Added ability to print status of the control module as a serialized string

Added tests for control module (none existed)

Alternative(s) considered
None

Type

Type Choose one: (Bug fix | Feature | Testing )

Screenshots (if applicable)

Checklist

  • I have read the Contribution Guidelines
  • I have written Unit Tests
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach

@mraduldubey mraduldubey changed the title Md/control module pipeline fixes control module pipeline fixes & added control module UTs Sep 30, 2024
Copy link

github-actions bot commented Sep 30, 2024

Test Results Windows-cuda

  1 files  ±0    1 suites  ±0   12m 17s ⏱️ +10s
410 tests +2  293 ✅ +1  117 💤 +1  0 ❌ ±0 
293 runs  +1  176 ✅ ±0  117 💤 +1  0 ❌ ±0 

Results for commit 6f90a5d. ± Comparison against base commit 9ecea0d.

♻️ This comment has been updated with latest results.

base/include/AbsControlModule.h Outdated Show resolved Hide resolved
base/include/PipeLine.h Outdated Show resolved Hide resolved
base/src/AbsControlModule.cpp Outdated Show resolved Hide resolved
base/src/PipeLine.cpp Outdated Show resolved Hide resolved
base/src/PipeLine.cpp Show resolved Hide resolved
Copy link

github-actions bot commented Sep 30, 2024

Test Results Linux

  1 files  ±0    1 suites  ±0   10m 16s ⏱️ +8s
315 tests +2  228 ✅ +1  83 💤 +1  4 ❌ ±0 
232 runs  +1  145 ✅ ±0  83 💤 +1  4 ❌ ±0 

For more details on these failures, see this check.

Results for commit 6f90a5d. ± Comparison against base commit 9ecea0d.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 30, 2024

Test Results Win-nocuda

  1 files  ±0    1 suites  ±0   10m 28s ⏱️ -1s
309 tests +2  232 ✅ +1  77 💤 +1  0 ❌ ±0 
232 runs  +1  155 ✅ ±0  77 💤 +1  0 ❌ ±0 

Results for commit 6f90a5d. ± Comparison against base commit 9ecea0d.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@kushaljain-apra kushaljain-apra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

base/src/Module.cpp Show resolved Hide resolved
base/include/SimpleControlModule.h Outdated Show resolved Hide resolved
base/src/AbsControlModule.cpp Show resolved Hide resolved
base/src/Module.cpp Outdated Show resolved Hide resolved
base/src/Module.cpp Show resolved Hide resolved
@mraduldubey mraduldubey merged commit bdc49cc into main Oct 3, 2024
11 of 16 checks passed
@mraduldubey mraduldubey deleted the md/controlModulePipelineFixes branch October 3, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control module thread handling issues
3 participants