Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gauntlet Legends: Implement New Game #3499

Open
wants to merge 147 commits into
base: main
Choose a base branch
from
Open

Gauntlet Legends: Implement New Game #3499

wants to merge 147 commits into from

Conversation

jamesbrq
Copy link
Contributor

@jamesbrq jamesbrq commented Jun 9, 2024

What is this fixing or adding?

Adds Gauntlet Legends on the N64 as a supported game.

How was this tested?

Through months of testing in both syncs and asyncs

If this makes graphical changes, please attach screenshots.

N/A

jamesbrq added 30 commits May 9, 2024 19:42
@jamesbrq
Initial upload
471741b
@jamesbrq
update
bb88fc0
@jamesbrq
Continuation of next update
6d2f0b8
@jamesbrq
Further continuation of update
d1dc652
@jamesbrq
Merge branch 'ArchipelagoMW:main' into gl
f3d92b0
@jamesbrq
Update GauntletLegendsClient.py
68ca69d
@jamesbrq
Continuation of obelisk update
a4f951d
@jamesbrq
Merge branch 'ArchipelagoMW:main' into gl
4471089
@jamesbrq
APPP Implementation Groundwork.
7e6efe0
@jamesbrq
Merge branch 'ArchipelagoMW:main' into gl
7c1b01c
@jamesbrq
Continuation of APPP Implementation
73bb4f2
@jamesbrq
Merge branch 'gl' of https://github.com/jamesbrq/ArchipelagoMainMLSS …
d8b5277 
…into gl
@jamesbrq
Create Pain.asm
56c9cb4
@jamesbrq
ROM verification modified since crc32 hash can no longer be calculated.
101e2e8
@jamesbrq
Merge branch 'ArchipelagoMW:main' into gl
4e30235
@jamesbrq
Initial upload of barrel/chest locations.
f4c976d
@jamesbrq
Finished adding and naming all chests/barrels.
4bb76d8
@jamesbrq
Continued locations.
65db3f0
@jamesbrq
Merge branch 'ArchipelagoMW:main' into gl
3747cff
@jamesbrq
Added new yaml options
51dfcee
@jamesbrq
Work on mirror shards
9d7f33b
@jamesbrq
Python 3.8 compatibility
2b40316
@jamesbrq
Finalized location names. Fixed lambda bug.
8f57ba1
@jamesbrq
v1.0
97e8789
@jamesbrq
Removed excess Docs and Changed item counts.
6cefac3
@jamesbrq
Update Archipelago Unittests.run.xml
21fedb1
@jamesbrq
Merge branch 'ArchipelagoMW:main' into gl
58c7339
@jamesbrq
Started working on Docs.
e68d01f
@jamesbrq
Merge branch 'ArchipelagoMW:main' into gl
745d9a9
@jamesbrq
Merge branch 'ArchipelagoMW:main' into gl
30140b2
@jamesbrq jamesbrq closed this Jan 6, 2025
@jamesbrq jamesbrq reopened this Jan 6, 2025
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jan 6, 2025
qwint
qwint reviewed Jan 15, 2025
View reviewed changes
worlds/gl/__init__.py Outdated Show resolved Hide resolved
@qwint qwint removed the affects: core Issues/PRs that touch core and may need additional validation. label Jan 15, 2025
qwint
qwint suggested changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@qwint qwint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skimmed rom-based code and docs and commented on anything that stood out, but not a full review on those parts
otherwise pure code review, I did run webhost and glance at the pages there, but otherwise ran no tests/gens/games

worlds/gl/__init__.py Outdated Show resolved Hide resolved
worlds/gl/GauntletLegendsClient.py Outdated Show resolved Hide resolved
worlds/gl/__init__.py Outdated Show resolved Hide resolved
worlds/gl/__init__.py Show resolved Hide resolved
worlds/gl/__init__.py Outdated Show resolved Hide resolved
worlds/gl/Regions.py Outdated Show resolved Hide resolved
worlds/gl/Regions.py Outdated Show resolved Hide resolved
worlds/gl/Regions.py Outdated Show resolved Hide resolved
worlds/gl/Regions.py Outdated Show resolved Hide resolved
worlds/gl/Rules.py Outdated Show resolved Hide resolved
qwint
qwint approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@qwint qwint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the World.disabled_locations classvar issue everything else at this point is nitpicks and looks good either way
again, pure code review, no tests/gens/games ran

worlds/gl/__init__.py Outdated Show resolved Hide resolved
worlds/gl/Rules.py Outdated Show resolved Hide resolved
worlds/gl/Regions.py Show resolved Hide resolved
worlds/gl/__init__.py Outdated Show resolved Hide resolved
worlds/gl/Options.py Outdated Show resolved Hide resolved
worlds/gl/Regions.py Outdated Show resolved Hide resolved
worlds/gl/__init__.py Outdated Show resolved Hide resolved
worlds/gl/__init__.py Outdated Show resolved Hide resolved
qwint
qwint reviewed Jan 17, 2025
View reviewed changes
worlds/gl/__init__.py Outdated Show resolved Hide resolved
qwint
qwint approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@qwint qwint left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

context of my review has not changed, but all my issues and requests are handled
test failure is an unrelated issue fixed on main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwint qwint qwint approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
is: new game Pull requests for implementing new games into Archipelago. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesbrq @qwint @Exempt-Medic