Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LADX: move client out of root #4226

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

threeandthreee
Copy link
Contributor

@threeandthreee threeandthreee commented Nov 22, 2024

What is this fixing or adding?

Moves the client out of root.

Much easier to distribute beta clients like this, and as I understand it we want this stuff out of root anyway.

How was this tested?

It's been in the beta build for a good while now with no reported issues.

@github-actions github-actions bot added the affects: core Issues/PRs that touch core and may need additional validation. label Nov 22, 2024
@threeandthreee
Copy link
Contributor Author

@palex00 would you mind testing?

@Berserker66
Copy link
Member

old client needs to be explicitly deleted in inno_setup.iss as well.

@Zunawe
Copy link
Collaborator

Zunawe commented Nov 22, 2024

If you're removing the top-level script entirely, you'll want to modify inno_setup.iss to change the windows file extension registration from the LADX client exe to the launcher exe.

@threeandthreee
Copy link
Contributor Author

Root: HKCR; Subkey: ".apladx";                                   ValueData: "{#MyAppName}ladxpatch";        Flags: uninsdeletevalue; ValueType: string;  ValueName: "";
Root: HKCR; Subkey: "{#MyAppName}ladxpatch";                     ValueData: "Archipelago Links Awakening DX Patch"; Flags: uninsdeletekey;   ValueType: string;  ValueName: "";
Root: HKCR; Subkey: "{#MyAppName}ladxpatch\DefaultIcon";         ValueData: "{app}\ArchipelagoLauncher.exe,0";                           ValueType: string;  ValueName: "";
Root: HKCR; Subkey: "{#MyAppName}ladxpatch\shell\open\command";  ValueData: """{app}\ArchipelagoLauncher.exe"" ""%1""";                  ValueType: string;  ValueName: "";

Like this?

@threeandthreee
Copy link
Contributor Author

old client needs to be explicitly deleted in inno_setup.iss as well.

I could use some guidance on how to do this

this seems like it?
@threeandthreee
Copy link
Contributor Author

I think I worked it out.

@threeandthreee threeandthreee marked this pull request as ready for review January 16, 2025 16:09
@Exempt-Medic Exempt-Medic added is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants